Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review React Guide #739

Closed
D4nte opened this issue May 13, 2022 · 4 comments
Closed

Review React Guide #739

D4nte opened this issue May 13, 2022 · 4 comments
Labels
good first issue Good for newcomers

Comments

@D4nte
Copy link
Contributor

D4nte commented May 13, 2022

When following https://docs.wakuconnect.dev/docs/guides/07_reactjs_relay/ with [email protected] I noticed that I only needed to install assert for the example to work:

  • cra-webpack-rewired and overriding the webpack config are not needed
  • No other polyfills are needed

The polyfills might only be needed when using specific modules (ie, Buffer might be used only for the cryptography).

We should better understand and document the polyfill needs, especially if it makes the library easier to use.

@D4nte D4nte added the good first issue Good for newcomers label May 13, 2022
@D4nte
Copy link
Contributor Author

D4nte commented May 13, 2022

Note assert was removed: #740

@D4nte
Copy link
Contributor Author

D4nte commented Jun 22, 2022

To be done when documenting @waku/core as part of #802.

@taylorferran
Copy link

Was this completed during #802 @fryorcraken ? And can it be closed

Just came across this when looking for a good first issue

@fryorcraken
Copy link
Collaborator

fryorcraken commented Dec 15, 2022

Closing this as all guides need to be reviewed.
Work to be planned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants