-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: setup size-limit report and define size budget #1435
Labels
test
Issue related to the test suite with no expected consequence to production code
Comments
|
5 tasks
fryorcraken
added
test
Issue related to the test suite with no expected consequence to production code
E:Comprehensive dev testing
See https://github.com/waku-org/pm/issues/90 for details
and removed
enhancement
New feature or request
labels
Sep 22, 2023
Quickly checked it and want to understand: why do we use custom action here? |
Because of this: andresz1/size-limit-action#84 |
1 task
Sharing basic knowledge on the
fyi @waku-org/js-waku-developers Having said that I am reshaping this issue to be part of #337 (updated body of the issue) |
weboko
changed the title
investigate size-limit report
feat: setup size-limit report and define size budget
Nov 28, 2023
chair28980
removed
the
E:Comprehensive dev testing
See https://github.com/waku-org/pm/issues/90 for details
label
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a feature request.
Problem
Right now we don't have any strategy for measuring and limiting size of
js-waku
package family.Proposed Solutions
Define maximum size limit for the packages in
js-waku
and re-configuresize-limit
config to check entry points of the packages and warn in PRs about violation.Notes
Running time from the
size-limit
report to be investigated as it doesn't seem as deterministic metric.The text was updated successfully, but these errors were encountered: