Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: setup size-limit report and define size budget #1435

Open
Tracked by #337
danisharora099 opened this issue Jul 25, 2023 · 4 comments
Open
Tracked by #337

feat: setup size-limit report and define size budget #1435

danisharora099 opened this issue Jul 25, 2023 · 4 comments
Labels
test Issue related to the test suite with no expected consequence to production code

Comments

@danisharora099
Copy link
Collaborator

danisharora099 commented Jul 25, 2023

This is a feature request.

Problem

Right now we don't have any strategy for measuring and limiting size of js-waku package family.

Proposed Solutions

Define maximum size limit for the packages in js-waku and re-configure size-limit config to check entry points of the packages and warn in PRs about violation.

Notes

Running time from the size-limit report to be investigated as it doesn't seem as deterministic metric.

@fryorcraken fryorcraken added this to Waku Jul 25, 2023
@danisharora099
Copy link
Collaborator Author

  • republish/move the size-limit script to a more accessible location
  • remove the fields that are not as useful (running time, etc)
  • look at coverage

@danisharora099 danisharora099 added the enhancement New feature or request label Aug 3, 2023
@danisharora099 danisharora099 moved this to To Do in Waku Aug 3, 2023
@fryorcraken fryorcraken added test Issue related to the test suite with no expected consequence to production code E:Comprehensive dev testing See https://github.com/waku-org/pm/issues/90 for details and removed enhancement New feature or request labels Sep 22, 2023
@weboko
Copy link
Collaborator

weboko commented Nov 4, 2023

Quickly checked it and want to understand: why do we use custom action here?

@fryorcraken

@fryorcraken
Copy link
Collaborator

Quickly checked it and want to understand: why do we use custom action here?

@fryorcraken

Because of this: andresz1/size-limit-action#84

@weboko
Copy link
Collaborator

weboko commented Nov 28, 2023

Sharing basic knowledge on the size-limit here:

  • right now we have test some entry points defined here;
  • size limit allows us to define some budget - here;
  • underseas it just runs exposed entry points and tests size / running time;

fyi @waku-org/js-waku-developers

Having said that I am reshaping this issue to be part of #337 (updated body of the issue)

@weboko weboko changed the title investigate size-limit report feat: setup size-limit report and define size budget Nov 28, 2023
@chair28980 chair28980 removed the E:Comprehensive dev testing See https://github.com/waku-org/pm/issues/90 for details label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issue related to the test suite with no expected consequence to production code
Projects
Status: To Do
Development

No branches or pull requests

4 participants