Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: setup shards #1256

Merged
merged 1 commit into from
Nov 22, 2024
Merged

fix: setup shards #1256

merged 1 commit into from
Nov 22, 2024

Conversation

richard-ramos
Copy link
Member

Description

go-waku waku command did not setup the list of shards on the ENR when relay was disabled. This ended up causing the node to not be able to connect due to the ENR not containing any shard. This change sets the list of shards regardless of relay being enabled or not

Fixes: #1255

@status-im-auto
Copy link

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 474fe3f #1 2024-11-20 14:33:10 ~2 min unknown 📄log

Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richard-ramos richard-ramos merged commit 96702e2 into master Nov 22, 2024
14 checks passed
@richard-ramos richard-ramos deleted the fix/shards-node branch November 22, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

bug: nim->gowaku interop lightpush and filter tests fail with invalid shard count error
3 participants