Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't convert app labels in config model IDs to lowercase #162

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Don't convert app labels in config model IDs to lowercase #162

wants to merge 1 commit into from

Conversation

ElectronicRU
Copy link

Although rare and not recommended, non-lowercase app labels do in fact exist, so support them the same way Django does.
(E.g. model._meta.label_lower doesn't lowercase the app label, neither does the app registry).

Fixes #161

@ElectronicRU
Don't convert app labels in config model IDs to lowercase
982c1e3 
Although rare and not recommended, non-lowercase app labels do in fact
exist, so support them the same way Django does.
(E.g. model._meta.label_lower doesn't lowercase the app label, neither
does the app registry).
@ElectronicRU
Copy link
Author

Note: relation.lower() in wagtail_transfer/field_adapters.py seems suspect to me. I left it in for now, but does Django normalize reverse-relation manager names? They don't correspond to DB entities, so probably not, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apps with non-lower name seem to be not supported
1 participant
@ElectronicRU