-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test vectors #43
Comments
Verified the 0.8.4 upgrade via these (assuring old compat) for the WASM interface - Additionally there are some more-pedantic e2e tests as well - The combination of these actually ensured compat with older keypairs, signatures for this specific wrapper. |
@jacogr this The problem is that I will copy these tests into sr25519-crust, and eventually test vectors will change (they already changed at least once after transition from 0.1.0 to 0.8.4). Then, implementers will not know which vectors to use, because implementation(s) are not synchronized. The best approach is to generate file similar to sign.input of ed25519, and put it somewhere inside repository. Then, this file will be a single source of truth for the test data. |
@Warchant Agree 100%, I think this issue also sums it up #36 - effectively there the current status is "ok, the time is right now, interfaces are stable, go for it" So I was not suggesting linking the above is the right long-term solution, just trying to show something that at least helps right at this point in time. |
I'm happy for any PRs on this. I'll try to do it myself in the near future if nothing materializes. |
Please, add test vectors, so other implementers can verify their implementations.
The text was updated successfully, but these errors were encountered: