-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to get correct connectStart/End, domainLookupStart/End value when service worker is enabled? #363
Comments
I believe you can get those values when looking at Resource Timing entries in the SW itself. Does that make sense? |
This is WAI. The problem with service worker responses is that they could have been fetched and cached before you even started your client fetch. One thing I was thinking we can do (WDYT @yoavweiss @nicjansma @tunetheweb?) is include something like an |
Sounds reasonably to me. But would be interested to hear @nicjansma 's view as to whether this would actually be useful. |
Yeah that sounds ideal to me as well. Would the |
Let's get @noamr 's opinion of this when he's back. I originally (misread?) "client" as being the service worker and so the timestamps were not altered to match the page, but re-reading it seems like I might be wrong there.
Not loving the |
I'm back soon! In the SW timeline you can already see the entry. So
Better! |
Summarizing conversation from the WG, there seems to be good sentiment towards having something like So the idea would be that the timing info is assigned to the response object, and gets copied when a service worker creates the client response object in |
When enabling service worker to proxy http requests, the connectStart/End, domainLookupStart/End returned from
performance.getEntriesByName
is the same asworkerStart
. And if I disable service worker, these values become "normal". My question is how I can get the real connection time metrics when service worker is involved?Below is a screenshot when service worker is enabled.
The text was updated successfully, but these errors were encountered: