Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty CSS custom values generate an error #1538

Open
user414 opened this issue Aug 5, 2023 · 1 comment
Open

Empty CSS custom values generate an error #1538

user414 opened this issue Aug 5, 2023 · 1 comment
Assignees
Labels
status: accepted Ready to be further processed type: false-positive This issue is about valid content being incorrectly rejected

Comments

@user414
Copy link

user414 commented Aug 5, 2023

Hello I'm also running with an issue similar to the one describe here

twbs/bootstrap#38061

when including part of the boostrap css in an epub V3 file as epubcheck is reporting an error on empty value for custom css properties. After verification I agree with the boostrap team that it is legal CSS for custom properties to be empty whereas it is not legal for regular properties to be empty and it seems it is a bug in epubcheck to report this as an error.

To replicate the error simply take the boostrap CSS here

https://cdn.jsdelivr.net/npm/[email protected]/dist/css/bootstrap.css

and include it in an epub3 file, then run epubcheck vs 5.0.1 and you will get an error like this:

ERROR(CSS-008): ../untitled.epub/OEBPS/Styles/main.css(2731,25): An error occurred while parsing the CSS: Token ";" not allowed here, expecting a property value.

@rdeltour
Copy link
Member

I agree this looks like a bug, good catch! If I remember correctly, EPUBCheck's custom CSS parser was implemented even before CSS custom properties were a thing. I'll look into it for the next milestone.

@rdeltour rdeltour self-assigned this Aug 31, 2023
@rdeltour rdeltour added this to the Next maintenance release milestone Aug 31, 2023
@rdeltour rdeltour added status: accepted Ready to be further processed type: false-positive This issue is about valid content being incorrectly rejected labels Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepted Ready to be further processed type: false-positive This issue is about valid content being incorrectly rejected
Projects
None yet
Development

No branches or pull requests

2 participants