Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression testing for rendering #660

Closed
8 of 9 tasks
w23 opened this issue Nov 21, 2023 · 2 comments
Closed
8 of 9 tasks

Regression testing for rendering #660

w23 opened this issue Nov 21, 2023 · 2 comments
Labels
autotest Things useful for automated testing/CI dev-tools Tools helpful for development enhancement New feature or request ray tracing

Comments

@w23
Copy link
Owner

w23 commented Nov 21, 2023

We want to check whether code changes affected the final rendered image. Some changes should not affect the final image at all.
For differences we want to figure out whether we broke things, or improved things.

Thus:

  • Have a collection of maps/savefiles for distinct rendering features. Make sure that all rendering functionality is covered (diffuse, specular, point, polygon lights, transparency, different objects, etc).
  • Have a set of expected screenshots.
    • Figure out which images we need.
  • Script to write screenshots
  • Utility to compare images
  • Script to compare all images
  • Script for running the entire test suite.
  • Where to store the above?
  • How to integrate with GH Actions CI? -> Integrate render tests into CI checks #725
@w23 w23 added enhancement New feature or request ray tracing dev-tools Tools helpful for development autotest Things useful for automated testing/CI labels Nov 21, 2023
@w23 w23 added this to HLRT Nov 21, 2023
@w23 w23 moved this to 🏗 In progress in HLRT Nov 21, 2023
@w23
Copy link
Owner Author

w23 commented Nov 30, 2023

Test suite with scripts, saves, and gold images is here: https://rtxash.omgwtf.ru/Half-Life-RTX/HLRTest
The only thing that remains is actions/CI integration

@w23
Copy link
Owner Author

w23 commented Jan 1, 2024

Integrating with CI will be done separately when lack of it starts to cause pain.
ref: #725

@w23 w23 closed this as completed Jan 1, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in HLRT Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autotest Things useful for automated testing/CI dev-tools Tools helpful for development enhancement New feature or request ray tracing
Projects
Status: Done
Development

No branches or pull requests

1 participant