-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues to resolve (and make the addon use Stable APIs) #5
Comments
Ohh interesting... I'll check it. |
Turns out server-ui isnt needed. |
hey @Assassin1065 thanks a bunch for all the work you put into the PRs and trying to get the addon working with the stable API. seriously, it means a lot, and I really appreciate the effort… but, after going through the changes and running the tests, I noticed some key stuff like:
aren't available yet in the stable API version you set (1.13.0). these are pretty important for the addon, and without them, some core features won’t work right :/ also, while the code looks good overall, the CI tests ended up failing 'cause of these missing features. additionally, we don't need so yeah, with that in mind, I’m gonna have to close the PRs and mark the issue as "wontfix" for now... but once those features are supported in the stable API, we can totally revisit it thanks again for all your contributions! really hope to see more from you down the road :) |
just let me know if there's anything we can improve! i'm also waiting for the game's API to be fully stable, but there are still a few things the addon needs to work around for now |
Gotcha. Those will still work with beta apis. I prefer working without beta apis so I overlooked these. I still think you should push some sort of update to this. |
Also adding the "minecraft:hand_equipped" component to the debug stick item will make it render just like a tool when held in hand, just like it does in java, and it would match the vanilla stick. |
ohh, sorry I didn’t notice that I closed that separate PR. i will go ahead and reopen it and do some checks |
rebased and merged #8 |
should I release a new patch now to accommodate the changes, or would you prefer to wait for a later update? edit: done. https://github.com/vytdev/debug-stick/releases/v1.10.1 edit 2: now waiting for mcpedl to approve the update |
just experimenting with github comments. ignore me Lines 159 to 185 in b5bfff1
|
@Assassin1065, I had:
* also i've seen your email |
Thanks! I couldn't find any discord or other social media. I just didnt want to see this abandoned lol. |
Also yeah. I post a lot on mcpedl lol |
{ "module_name": "@minecraft/server-ui", "version": "1.1.0" }, { "module_name": "@minecraft/server", "version": "1.13.0" }
"minecraft:hand_equipped": true,
to the debug stick item.The text was updated successfully, but these errors were encountered: