Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong feature support check when creating a device #2491

Open
Rua opened this issue Mar 8, 2024 · 0 comments
Open

Wrong feature support check when creating a device #2491

Rua opened this issue Mar 8, 2024 · 0 comments

Comments

@Rua
Copy link
Contributor

Rua commented Mar 8, 2024

Reported by @Fuzzyzilla on Discord.

When creating a device, the enabled features are checked against those supported by the physical device. But it does not check if those features will actually be available with the provided enabled extensions.

For example, if your device supports khr_dynamic_rendering (and not Vulkan 1.3) but you don't enable it, you can nonetheless enable the dynamic_rendering feature. Since VkPhysicalDeviceDynamicRenderingFeaturesKHR is not available without the extension, it does not get passed to the device creation, and the feature gets silently ignored. But Vulkano goes by the original DeviceFeatures struct, not the subset that gets passed through to Vulkan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants