Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After new version is updated it doesn't launch app automatically #132

Open
jiakuan opened this issue Mar 3, 2017 · 4 comments
Open

After new version is updated it doesn't launch app automatically #132

jiakuan opened this issue Mar 3, 2017 · 4 comments

Comments

@jiakuan
Copy link

jiakuan commented Mar 3, 2017

This is more like a question than an issue. I asked this in StackOverflow but it seems no one knows the answer. Apologies if I should not create an issue for this one. BTW, is there a maillist to discuss this kind of things?

I'm using WinSparkle (latest version 0.5.3) framework in my Qt C++ app for auto-update. It works perfectly with detecting new version, downloading and installing the new version automatically.

But I found after the new version is installed, it doesn't launch the app automatically, and users have to launch it manually.

I checked the WinSparkle API reference, and didn't find any settings related to this. I think WinSparkle should have built-in support for auto-launching the app after update?

Is there a way in WinSparkle to handle it in the same way as Sparkle does?

@jiakuan
Copy link
Author

jiakuan commented Mar 3, 2017

I realised the situation might be different between Windows and Mac OS X.

On Windows, perhaps the solution could be to implement this auto-launching inside the installer, e.g. MSI or EXE. Therefore, no need to have this in WinSparkle.

If anyone can confirm that I didn't miss anything available in WinSparkle, I will then close this ticket. Thanks a lot!

@vslavik
Copy link
Owner

vslavik commented Mar 3, 2017

I realised the situation might be different between Windows and Mac OS X.

Indeed. Sparkle has it easy: just replace the files in a bundle; it's also obvious what you launch (the bundle, there's exactly one launchable thing). Neither is true on Windows. At the moment, it's your responsibility to fix your installer to relaunch (or have an option to launch, checked by default) after it's done installing.

That said, ideally there would be a mechanism to detect if the installer finished and didn't re-launch, and/or a silent mode where this can be under WinSparkle's control, as well as a Sparkle-like update mechanism where files are updated from a ZIP and re-launching is managed by WinSparkle. Any PRs to that effect, even partial, would always be most welcome.

@jiakuan
Copy link
Author

jiakuan commented Mar 3, 2017

I would be nice to be able to update from a ZIP file and re-launch automatically. For now, it's enough to implement that in the Windows installer for me.

I would love to dive in and have a look at the possibility of contributing a PR for this. But unfortunately I'm time poor at the moment.

If you have any guidelines about the best way to implement this new feature (e.g. which class can be created or modified), that would be very helpful.

@patrickkidd

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants