Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Test if we can build puppetboard & install setuptools #1202

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bastelfreak
Copy link
Member

In our normal test pipeline, we didn't verify if we can properly build the package. because of that, the last 6.0.0 release failed:

Run python setup.py build sdist bdist_wheel
Traceback (most recent call last):
  File "/home/runner/work/puppetboard/puppetboard/setup.py", line 3, in <module>
    from setuptools.command.test import test as TestCommand
ModuleNotFoundError: No module named 'setuptools'

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.89%. Comparing base (2f21617) to head (c09b0dd).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1202   +/-   ##
=======================================
  Coverage   76.89%   76.89%           
=======================================
  Files          20       20           
  Lines        1307     1307           
=======================================
  Hits         1005     1005           
  Misses        302      302           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

In our normal test pipeline, we didn't verify if we can properly build
the package. because of that, the last 6.0.0 release failed:

```
Run python setup.py build sdist bdist_wheel
Traceback (most recent call last):
  File "/home/runner/work/puppetboard/puppetboard/setup.py", line 3, in <module>
    from setuptools.command.test import test as TestCommand
ModuleNotFoundError: No module named 'setuptools'
```
@bastelfreak bastelfreak changed the title CI: Test if we can build puppetboard CI: Test if we can build puppetboard & install setuptools Nov 26, 2024
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we need to declare setuptools as a dependency in some way. Or migrate to pyproject.toml. https://packaging.python.org/en/latest/guides/writing-pyproject-toml/ says we can declare setuptools as the build system:

[build-system]
requires = ["setuptools >= 61.0"]
build-backend = "setuptools.build_meta"

No idea if we really need >= 61.0 or any version.

runs-on: ubuntu-latest
strategy:
matrix:
python-version: [3.9, '3.10', 3.11, 3.12, 3.13]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm always a fan of the multi-line version so you can easily add and remove lines with a readable diff

@bastelfreak
Copy link
Member Author

I'm wondering if we need to declare setuptools as a dependency in some way

I do not know enough about python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants