Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept Datatype Sensitive[String] for Passwords #950

Open
cocker-cc opened this issue Jun 11, 2024 · 2 comments · May be fixed by #973 or #857
Open

Accept Datatype Sensitive[String] for Passwords #950

cocker-cc opened this issue Jun 11, 2024 · 2 comments · May be fixed by #973 or #857
Milestone

Comments

@cocker-cc
Copy link

To not reveal sensitive Data accept Datatype Sensitive[String] for Passwords.

Motivation for this is: Authors of Profilemodules should not be bothered with dealing with Datatype Sensitive. Componentmodules (like zabbix) should take Care of this.

Examples:

class zabbix (
  Variant[Sensitive[String], String] $database_password = $zabbix::params::server_database_password,
) {}
class zabbix::database (
  Variant[Sensitive[String], String] $database_password = $zabbix::params::server_database_password,
) {}
@Valantin
Copy link
Contributor

@cocker-cc thanks could you please provide a PR for this please?

@Valantin Valantin added this to the 10.1.0 milestone Jun 17, 2024
@Valantin Valantin modified the milestones: 10.1.0, 11.0.0 Jun 28, 2024
@teluq-pbrideau
Copy link
Contributor

@Valantin @cocker-cc I did a PR with this change previously (#857) but it never moved forward. I’ll try to rebase with master and propose the changes, but it might be a lot of work, and might be easier to start from scratch… I’m not sure

@cocker-cc cocker-cc linked a pull request Jul 9, 2024 that will close this issue
@teluq-pbrideau teluq-pbrideau linked a pull request Jul 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants