Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update legacy facts #404

Open
voreilly opened this issue Oct 10, 2024 · 3 comments · May be fixed by #406
Open

Update legacy facts #404

voreilly opened this issue Oct 10, 2024 · 3 comments · May be fixed by #406

Comments

@voreilly
Copy link

Affected Puppet, Ruby, OS and module versions/distributions

  • Ruby:

How to reproduce (e.g Puppet code you use)

Use mod 'benjaminrobertson-find_legacy_facts', '0.2.0' and run again an environment on your puppet master node

What are you seeing

File: selinux/lib/puppet/provider/selinux_fcontext/semanage.rb contains legacy fact selinux on line 10
File: selinux/lib/puppet/provider/selinux_fcontext_equivalence/semanage.rb contains legacy fact selinux on line 9
File: selinux/lib/puppet/provider/selinux_permissive/semanage.rb contains legacy fact selinux on line 8
File: selinux/lib/puppet/provider/selinux_port/semanage.rb contains legacy fact selinux on line 8
File: selinux/lib/puppet/provider/selinux_login/semanage.rb contains legacy fact selinux on line 8

What behaviour did you expect instead

Please use os.selinux.enabled instead of just selinux

Output log

Any additional information you'd like to impart
@voreilly
Copy link
Author

Also forgot to add in one more legacy fact:
selinux/lib/facter/selinux_python_command.rb contains legacy fact osfamily on line 5; use os.family

@kenyon
Copy link
Member

kenyon commented Oct 10, 2024

Can you provide a pull request? Thanks!

@voreilly
Copy link
Author

Sure kenyon, just created a pull request. Cheers

@kenyon kenyon linked a pull request Oct 10, 2024 that will close this issue
Update legacy facts #406
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update legacy facts voreilly/puppet-selinux
2 participants
@kenyon @voreilly