Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about OS-default configurations #193

Open
dploeger opened this issue Mar 16, 2022 · 4 comments
Open

Question about OS-default configurations #193

dploeger opened this issue Mar 16, 2022 · 4 comments

Comments

@dploeger
Copy link

Just a clarification for me here.

Do I see this correctly, that the module does not include the OS' default configuration that you'd get when you just install rsyslog? I see that /etc/rsyslog.conf and /etc/rsyslog.d is replaced (if you not set purge_config_files to false), but the configuration from these files isn't prevailed.

So if we'd want to use the module on our network, we'd have to include all the defaults for the different OSes we're managing ourselves, right?

@antaflos
Copy link

Replying to this old comment to confirm, for anyone else confused by this (like me): this module does indeed not provide any default configuration. Nothing generic and nothing OS-specific. It will, however, delete any default configuration that was put in place by the package manager and leave you with a non-functioning, unable-to-start rsyslog service.

Nothing in the README indicates this would be the case. On the contrary, the README explicitly states that just doing include rsyslog::config will "get you basic configuration for Rsyslog on your system". This is false. Instead it deletes any files in /etc/rsyslog.d and reduces /etc/rsyslog.conf to a single IncludeConfig directive.

So to people new to this module (if any): be sure to define the rsyslog configuration you expect before deploying this module, and maybe turn off purging of config files.

@peelman
Copy link

peelman commented Aug 10, 2024

Just got bit by this when trying to migrate from @saz's module to this one. This is some serious Neckbeard stuff. Rsyslog is hard enough to grok, outright removing sane defaults is pretty horrible behavior.

@TheMeier
Copy link

@peelman that is your opinion. IMHO it is actually a good thing, most defaults that I have seen so far don't do at all what I want.
I agree the docs could be better, but I like that it keeps the default OS config unless you do actually include rsyslog::config. And it is not that trivial, eg debian12 still ships a default config in the old format :(

But as usual merge requests are always welcome :)

@peelman
Copy link

peelman commented Aug 14, 2024

@peelman that is your opinion. IMHO it is actually a good thing, most defaults that I have seen so far don't do at all what I want. I agree the docs could be better, but I like that it keeps the default OS config unless you do actually include rsyslog::config. And it is not that trivial, eg debian12 still ships a default config in the old format :(

But as usual merge requests are always welcome :)

Have you tried submitting a merge request to the rsyslog folks with your preferred defaults that may be more useful?

image

This statement is in fact, a lie. It does quite the opposite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants