Don't use the $name for the owner / group settings (mcollective::user)

[khaefeli]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: 4.10.10
• Distribution: Debian 8
• Module version: 3.1.0

How to reproduce (e.g Puppet code you use)

I followed the example:
https://github.com/voxpupuli/puppet-mcollective/blob/master/examples/ssl_example/mco_profile/manifests/client.pp#L11

What are you seeing

Error: Could not find user control_client
Error: /Stage[main]/Profile::Mco::Control/Mcollective::User[control_client]/File[/root/.mcollective.d]/owner: change from root to control_client failed: Could not find user control_client
Error: /Stage[main]/Profile::Mco::Control/Mcollective::User[control_client]/File[/root/.mcollective.d]/group: change from root to control_client failed: Could not find group control_client

puppet tries to set the owner / group of the folder to $hostname::_client
my hostname is "control"

What behaviour did you expect instead

Setting the /root/.mcollective.d/ owner / group to root.

Output log

Any additional information you'd like to impart

Don't use the $name for owner / group.