Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider using libgit2 to avoid issues with wonky clients or configurations #45

Open
igalic opened this issue May 8, 2015 · 4 comments
Milestone

Comments

@igalic
Copy link
Contributor

igalic commented May 8, 2015

ruby-git/ruby-git#231 <- 2 hours of debugging with 2 two engineers.

@danzilio danzilio added this to the 2.0 milestone Oct 7, 2015
@rski
Copy link
Member

rski commented Mar 14, 2016

Does this still need to be done? If yes, will it be done with rugged?
I could look into producing a prototype over the next few weeks.

@igalic
Copy link
Contributor Author

igalic commented Mar 14, 2016

it's on the roadmap
and any work on it would be very welcome

@rski
Copy link
Member

rski commented Mar 15, 2016

Turns out there is one very important thing that ruby-git provides: Authentication with the git client.
libgit2 does authentication programmatically, so a user interface (file? command line input?) would need to be implemented to get authentication*.
The problem is that implementing anything for this would just be redoing work that already exists in the actual git client, which is why ruby-git just wraps git.
I think trying to purge ruby-git's options hash before running any git commands might solve the second part of this issue, i.e. wonky configurations. I'm not sure how sane and doable that would be though.
Idk for now, I'll have to play with this a bit more and see how it goes.

*Unless there is a way to get this done in libgit2/rugged that I didn't see in the docs

@igalic
Copy link
Contributor Author

igalic commented Mar 15, 2016

@rski thank you very much for the research!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants