Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librarian stopped working with latest minitar v1 release #122

Open
der-eismann opened this issue Aug 13, 2024 · 6 comments
Open

librarian stopped working with latest minitar v1 release #122

der-eismann opened this issue Aug 13, 2024 · 6 comments

Comments

@der-eismann
Copy link

der-eismann commented Aug 13, 2024

It turns out that the puppet_forge gem has a dependency on minitar without a version requirement on it (https://github.com/puppetlabs/forge-ruby/blob/main/puppet_forge.gemspec#L26) and is still using the old archive/tar/minitar namespace. However a few days ago minitar had it's v1 major release, abandoning the old namespace, causing issues with librarian:

$ librarian-puppet install --clean
<internal:/opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:86:in `require': cannot load such file -- archive/tar/minitar (LoadError)
	from <internal:/opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:86:in `require'
	from /opt/puppetlabs/puppet/lib/ruby/gems/3.2.0/gems/puppet_forge-4.1.0/lib/puppet_forge/tar/mini.rb:2:in `<top (required)>'
	from <internal:/opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:86:in `require'
	from <internal:/opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:86:in `require'
	from /opt/puppetlabs/puppet/lib/ruby/gems/3.2.0/gems/puppet_forge-4.1.0/lib/puppet_forge/tar.rb:4:in `<class:Tar>'
	from /opt/puppetlabs/puppet/lib/ruby/gems/3.2.0/gems/puppet_forge-4.1.0/lib/puppet_forge/tar.rb:3:in `<module:PuppetForge>'
	from /opt/puppetlabs/puppet/lib/ruby/gems/3.2.0/gems/puppet_forge-4.1.0/lib/puppet_forge/tar.rb:2:in `<top (required)>'
	from <internal:/opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:86:in `require'
	from <internal:/opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:86:in `require'
	from /opt/puppetlabs/puppet/lib/ruby/gems/3.2.0/gems/puppet_forge-4.1.0/lib/puppet_forge.rb:21:in `<module:PuppetForge>'
	from /opt/puppetlabs/puppet/lib/ruby/gems/3.2.0/gems/puppet_forge-4.1.0/lib/puppet_forge.rb:3:in `<top (required)>'
	from <internal:/opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:86:in `require'
	from <internal:/opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:86:in `require'
	from /opt/puppetlabs/puppet/lib/ruby/gems/3.2.0/gems/librarian-puppet-5.0.0/lib/librarian/puppet/source/forge/repo_v3.rb:2:in `<top (required)>'
	from <internal:/opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:86:in `require'
	from <internal:/opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:86:in `require'
	from /opt/puppetlabs/puppet/lib/ruby/gems/3.2.0/gems/librarian-puppet-5.0.0/lib/librarian/puppet/source/forge.rb:4:in `<top (required)>'
	from <internal:/opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:86:in `require'
	from <internal:/opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:86:in `require'
	from /opt/puppetlabs/puppet/lib/ruby/gems/3.2.0/gems/librarian-puppet-5.0.0/lib/librarian/puppet/source.rb:3:in `<top (required)>'
	from <internal:/opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:86:in `require'
	from <internal:/opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:86:in `require'
	from /opt/puppetlabs/puppet/lib/ruby/gems/3.2.0/gems/librarian-puppet-5.0.0/lib/librarian/puppet/dsl.rb:3:in `<top (required)>'
	from <internal:/opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:86:in `require'
	from <internal:/opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:86:in `require'
	from /opt/puppetlabs/puppet/lib/ruby/gems/3.2.0/gems/librarian-puppet-5.0.0/lib/librarian/puppet/environment.rb:2:in `<top (required)>'
	from <internal:/opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:86:in `require'
	from <internal:/opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:86:in `require'
	from /opt/puppetlabs/puppet/lib/ruby/gems/3.2.0/gems/librarian-puppet-5.0.0/lib/librarian/puppet/extension.rb:1:in `<top (required)>'
	from <internal:/opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:86:in `require'
	from <internal:/opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:86:in `require'
	from /opt/puppetlabs/puppet/lib/ruby/gems/3.2.0/gems/librarian-puppet-5.0.0/lib/librarian/puppet.rb:4:in `<top (required)>'
	from <internal:/opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:86:in `require'
	from <internal:/opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:86:in `require'
	from /opt/puppetlabs/puppet/lib/ruby/gems/3.2.0/gems/librarian-puppet-5.0.0/lib/librarian/puppet/cli.rb:4:in `<top (required)>'
	from <internal:/opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:86:in `require'
	from <internal:/opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:86:in `require'
	from /opt/puppetlabs/puppet/lib/ruby/gems/3.2.0/gems/librarian-puppet-5.0.0/bin/librarian-puppet:6:in `<top (required)>'
	from /opt/puppetlabs/puppet/bin/librarian-puppet:25:in `load'
	from /opt/puppetlabs/puppet/bin/librarian-puppet:25:in `<main>'

I opened puppetlabs/forge-ruby#119 to fix this temporarily, however librarian isn't even using forge-ruby v5 and I'm not sure if/when this change will land. Maybe this helps someone else or somebody at puppet can speed things up a bit, it feels like the whole ecosystem is pretty outdated unfortunately.

My workaround so far:

gem install --no-document librarian-puppet -v '~> 5'
gem uninstall minitar -I
gem install --no-document minitar -v '0.12'
@ekohl
Copy link
Member

ekohl commented Aug 13, 2024

I opened puppetlabs/forge-ruby#119 to fix this temporarily

This was merged and released

however librarian isn't even using forge-ruby v5 and I'm not sure if/when this change will land

There was 4bf2503 (which has a wrong summary). Let's create a new release that includes it.

@teluq-pbrideau
Copy link

Any chance for this new release of librarian-puppet on rubygems.org soon?

@parkr
Copy link

parkr commented Oct 7, 2024

+1, I am having this issue as well. To work around it, I downgraded to minitar 0.12.1.

@der-eismann
Copy link
Author

@bastelfreak can you tag a new release that includes 4bf2503? It's been over 3 months now where librarian is straight up broken without a workaround.

@bastelfreak
Copy link
Member

Hi,
as you can see in #123, we currently don't have a working CI. And I don't have the time right now to fix this. If you can take a look, we can make a new release afterwards.

@parkr
Copy link

parkr commented Nov 19, 2024

@der-eismann FWIW I downgraded minitar to pre-1.0 and this worked for me to get librarian working great again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants