-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve examples in README to add common security related headers #583
Comments
@sbp-bvanb thanks for the suggestion Could you expand on this a bit? What's your motivation here? What problem are you trying to solve? Is this kubernetes specific? Is this CORS specific? You should be able to add custom headers to the http request in NGINX. |
A number of default security headers should be present in multiple layers, also on application level like:
Other application like Grafana and ArgoCD do this as well if a request is issued to their services. |
@sbp-bvanb I'm of the opinion that such headers should be added via NGINX https://nginx.org/en/docs/http/ngx_http_headers_module.html There are many security related headers and each have their subtle nuances. I could see improving the documentation to highlight best practices. Would you be interested in developing a PR to make that addition? |
In my opinion it should be resolved in the code as well. In our case we have an AWS ALB and the Nginx-ingress controller cannot configure the headers there. Instead of putting an AWS CloudFront everywhere, it should be resolved in all layers. I am willing to create a code and documentation change the upcoming weeks and create a PR. |
This shows a method of adding headers to the ingress controller. Is that a workable solution for you? |
Yes tried that today, but is not working in conjunction with an AWS ALB. |
Something like custom headers: https://kubernetes.github.io/ingress-nginx/user-guide/nginx-configuration/annotations/#custom-headers
By default, the voucher should set some default headers in the response like Referrer-Policy
The text was updated successfully, but these errors were encountered: