-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS β Open Drawer Animation Bug (v2.0.0) π #212
Comments
Just upgraded from V1.2.4, which worked fine for me using ANIMATION_PARALLAX_FACTOR_7, to V2.0.0 and have the same issue with the black vertical line. |
What's up, @MarkBoyer? β you can fix the vertical black line issue as suggested in the Side Note of the comment above (preferred method) or try setting Ti's default backgroundColor to something like the below (in Hopefully this helps until a better solution (or fix) is made to the sub module MMDrawerController π |
Thanks for the quick reply @designbymind. I made the change to the module that you suggest and rebuilt it and while the block vertical stripe is gone, it's still not visually pleasing IMHO. There seems to be a bigger issue with the slide. Unfortunately, the native stuff is not my strong suit. I just changed to using the "ANIMATION_FADE" animation mode and is looks much better to me. Perhaps someone with more native experience can fix this. |
@MarkBoyer β Right on. Something was definitely broken in v.2.0.0 in regards to any animation that 'pulls' the drawer. The only two animation modes that I've noted to work as expected are: |
Same problem with "ANIMATION_SLIDE_SCALE" (V 2.0.0). Opening the drawer results in a blank view while animating and - after animation has been ended - the view is shown. |
Any update on this? Can anyone offer a starting point on how to fix this? |
When opening a drawer with
toggleLeftWindow()
or via pan gesture cancel (line 1059), the animation does not begin (or complete) until the drawer has finished opening (1.0/100%). See attached screencast) π½οΈ (usingANIMATION_SLIDE
).Note(s):
Β· Tested with left drawer only
Β· Animation methods which do not require the centerWindow to 'pull' the drawer window (ex.
ANIMATION_FADE
orANIMATION_NONE
) seem to work fineΒ· Seems to affect opening of the drawer only (closing works as expected)
Β· Maybe
CATransform3DMakeTranslation
?Side Note:
Β· The thin black vertical line shown in the screencast can be fixed by removing this line or possibly by setting
[self.view setBackgroundColor:[UIColor blackColor]];
to[self.view setBackgroundColor:[UIColor clearColor]];
β Most prominent when using
ANIMATION_SLIDE
& a light theme (background color) on leftDrawer and centerWindowEnvironment:
Β· dk.napp.drawer: 2.0.0
Β· TiSDK: 7.1.0.v20180108165029 (app relies on: https://jira.appcelerator.org/browse/TIMOB-24404)
Β· Alloy: 1.10.7
Β· Hyperloop: 3.0.1
Β· iOS: 10.3 & 11.2
Β· Device(s): iPhone 6s (10.3.3) & iPhone X (11.2.2)
Β· Simulator: iPhone X (11.2)
The text was updated successfully, but these errors were encountered: