Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML shorthands breaking custom elements #834

Open
MalifaciousGames opened this issue May 6, 2024 · 1 comment
Open

HTML shorthands breaking custom elements #834

MalifaciousGames opened this issue May 6, 2024 · 1 comment
Assignees
Labels
2.X Issues for the 2.X branch

Comments

@MalifaciousGames
Copy link

Hi, it seems the - shorthand for hidden elements messes with the parsing of custom elements, making them impossible to use : <custom-elem></custom-elem> renders as <custom style="display:none"></custom>.

I would gladly submit a pull request but I've been struggling to find when this parsing actually occurs in the rendering process.

@videlais videlais added the 2.X Issues for the 2.X branch label Aug 27, 2024
@videlais
Copy link
Owner

@MalifaciousGames I'm not surprised to learn that. I incorporated some older ideas into Snowman 2 and these have led to a number of problems. If you really want to work on this issue, it is part of the 2.X branch (https://github.com/videlais/snowman/blob/2.X/lib/Passage.js#L75).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.X Issues for the 2.X branch
Projects
Status: Backlog
Development

No branches or pull requests

2 participants