Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toil-vg construct fails at building the GBWT index if you haven't specially specified --vcf_phasing files #827

Open
ruolin opened this issue Jan 1, 2021 · 1 comment

Comments

@ruolin
Copy link

ruolin commented Jan 1, 2021

require(len(options.vcf_phasing) > 0, 'generating a GBWT requires a VCF with phasing information'). After delete _phasing it works again.

@adamnovak
Copy link
Member

I don't think deleting _phasing from the code is the right fix here.

If you want a GBWT, right now you have to feed your VCFs to toil-vg construct via --vcf_phasing (for making the GBWT) in addition to via --vcf (for making the graph). If you turn off the check against --vcf_phasing being empty, you might just get an empty GBWT.

What we ought to do is use --vcf files if --vcf_phasing is not specified.

@adamnovak adamnovak changed the title construct fail toil-vg construct fails at building the GBWT index if you haven't specially specified --vcf_phasing files Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants