Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edge_index doesn't say if the edge has to be canonical or not. #40

Open
adamnovak opened this issue Jan 6, 2020 · 2 comments
Open

edge_index doesn't say if the edge has to be canonical or not. #40

adamnovak opened this issue Jan 6, 2020 · 2 comments

Comments

@adamnovak
Copy link
Member

VectorizableHandleGraph::edge_index should state that the edge_t has to be from for_each_edgeor edge_handle (i.e. in canonical order and orientation).

@jeizenga
Copy link
Contributor

jeizenga commented Jan 6, 2020

Seems to me it should be pretty easy to canonicalize internally

@adamnovak
Copy link
Member Author

It kind of depends on if we want people to construct their own edge_t values ever, or if they are supposed to be opaque like handles.

Since there's no accessors into them other than .first and .second, I guess we should actually regard them as non-opaque and canonicalize the input edges.

@adamnovak adamnovak changed the title edge_index deosn't say if the edge has to be canonical or not. edge_index doesn't say if the edge has to be canonical or not. Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants