WIP: Retry-on-failure using NIH approach #100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veox
changed the title
Thanks to /u/FBAThrow for reminding! https://www.reddit.com/r/krakenex/comments/778uvh/psa_http_error_502_does_not_mean_the_query_wont/dqwlc1a/
veox
force-pushed
the
retry-on-failure
branch
from
8597ad8 to
b913d8d
Compare
Conflicts (resolved) * CHANGELOG.rst * krakenex/api.py
|
I've been live-testing this since the PR was opened. An undesirable quirk that's surfaced with this is that, should a query fail even after |
|
. |
This was referenced Feb 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporates PR #65.
Merged
masterand fixed conflicts (due to v2.1.0 released that happened in the meantime).This PR: