-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
built-in graphql playground has buggy tooltips #3244
Comments
The GraphQL sandbox that Vendure uses by default is deprecated. Change your vendure-config.ts file to look like this to use the more modern Apollo GraphQL Studio: import { ApolloServerPluginLandingPageLocalDefault } from '@apollo/server/plugin/landingPage/default';
export const config: VendureConfig = {
// ... other stuff ...
apiOptions: {
// ... other stuff ...
shopApiPlayground: false,
adminApiPlayground: false,
apolloServerPlugins: IS_DEV
? [ApolloServerPluginLandingPageLocalDefault()]
: [],
}
},
// ... more other stuff ...
}; |
@toBeOfUse It worked, tks man |
Thanks for providing that work-around. I think ultimately we need to consider moving to that in the core. But I'm not sure whether I like that particular one provided by Apollo, because the whole app is served from Apollo's servers. I'd prefer something self-contained. Ideally, we can use graphiql and wrap it into an Apollo plugin that implements the renderLandingPage method. |
It's true that the third-party cookies and prompts to log into Apollo are annoying - I'll look into this tonight |
We can definitely compile GraphiQL into a single HTML file and return it from an Apollo server plugin. The downsides are: the resulting HTML file, minified, is 1.5mb, which is kind of large, and React and some kind of bundler have to be added as dependencies (dev dependencies, if the bundling is done in advance), presumably to the core package. I'll open a PR for it, but I could see why one might end up wanting to go a different direction with this. |
A version of this now exists in #3246 |
Describe the bug
In http://localhost:3000/admin-api has a bug that makes code mirror-hint show up and doesn't disappear, and It stays there forever
To Reproduce
Steps to reproduce the behavior:
Expected behavior
I think It should be disappear
Environment (please complete the following information):
The text was updated successfully, but these errors were encountered: