Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong variable type (uint16) for pre_heater_temp_before and post_heater_temp_after #39

Open
panosnl opened this issue Dec 10, 2022 · 3 comments

Comments

@panosnl
Copy link

panosnl commented Dec 10, 2022

Today the temps dropped below zero and I noticed that one temp started showing wrong values. Since it was OK for T >0 I checked the code where it was declared as uint16

message.cpp, line 186:
LAZYSWITCH(220, "pre_heater_temp_before", "%.1f", uint16/10.0) // C°
LAZYSWITCH(221, "post_heater_temp_after", "%.1f", uint16/10.0) // C°

Changing it to int16 should solve the problem (I have to wait for tonight to confirm..)

LAZYSWITCH(220, "pre_heater_temp_before", "%.1f", int16/10.0) // C°
LAZYSWITCH(221, "post_heater_temp_after", "%.1f", int16/10.0) // C°

@nebman
Copy link

nebman commented Dec 12, 2022

Can confirm the problem over here with negative temps

$ mosquitto_sub -t "comfoair/pre_heater_temp_before" -v
comfoair/pre_heater_temp_before 6552.6

@svde
Copy link
Contributor

svde commented Dec 17, 2022

rmot is probably also affected.

@vekexasia
Copy link
Owner

fixed in #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants