Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: create a release-plz action #884

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jdrouet
Copy link
Contributor

@jdrouet jdrouet commented Jun 10, 2024

This PR creates a configuration for release-plz.
To make this work, we need to follow the first 2 steps from this doc. This will add a secret token that will allow this new action to publish the new release to crates.io.

Fixes #880

Signed-off-by: Jérémie Drouet <[email protected]>
@jdrouet jdrouet requested a review from pront June 10, 2024 18:30
@jdrouet jdrouet added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jun 10, 2024
@pront
Copy link
Collaborator

pront commented Jun 17, 2024

Hey @jdrouet, thanks for this. Is this a replacement for just publishing to crates.io? Could we also make it publish a version tag?

@jdrouet
Copy link
Contributor Author

jdrouet commented Jun 26, 2024

Hey @jdrouet, thanks for this. Is this a replacement for just publishing to crates.io? Could we also make it publish a version tag?

It should generate version tags, readmes and publish to crates.io. The complete process.

@pront
Copy link
Collaborator

pront commented Jul 1, 2024

To make this work, we need to follow the first 2 steps from this doc. This will add a secret token that will allow this new action to publish the new release to crates.io.

Hi @jdrouet, this looks promising. Are you willing to followup with the remaining steps and demonstrate how to create the next VRL release?

@pront pront requested a review from jszwedko July 3, 2024 17:36
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I agree this looks promising. A couple of questions:

  • Would this let us delete some of the release scripts currently in scripts/?
  • It seems like this publishes on every push to main. Do we want that?
  • Agreed with @pront that we should document this. I'd suggest doing so in the README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install release-plz to simplify release procedure
3 participants