fix(loki sinks): Fix loki event timestamp out of range panic #20780
+53
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgehermo9
reviewed
Jul 3, 2024
src/sinks/loki/tests.rs
Outdated
| let mut sink = LokiSink::new(config, client).unwrap(); | ||
|
|
||
| let mut e1 = LogEvent::from("hello world"); | ||
| use vector_lib::config::log_schema; |
There was a problem hiding this comment.
should we move this use statement to the beginning of this tests module?
jszwedko
reviewed
Jul 3, 2024
src/internal_events/loki.rs
Outdated
|
|
||
| impl InternalEvent for LokiEventTimestampOutOfRangeError { | ||
| fn emit(self) { | ||
| error!( |
There was a problem hiding this comment.
Should we make this a warn! since it doesn't actually inhibit processing? Also, what happens when we send an event to Loki without a timestamp? Does it just use the current timestamp?
There was a problem hiding this comment.
According to Loki api, timestamp is must.
jorgehermo9
reviewed
Jul 5, 2024
src/sinks/loki/tests.rs
Outdated
|
|
||
| #[tokio::test] | ||
| async fn timestamp_out_of_range() { | ||
| use vector_lib::config::log_schema; |
There was a problem hiding this comment.
I meant the beggining of this module, about line 10. It is more idiomatic to have all the use statements at the begginning of the module, so we don't have to dive into each scope and find those statements.
What do you think?
There was a problem hiding this comment.
Get it, check the new commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #20763