-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GELF codec needs to support chunking #13292
Comments
This should be attempted after #4868 is closed. |
Any update on this matter? |
👋 I've added it to our backlog. It currently doesn't have a high priority essentially due to not knowing how important it is to the community. Please vote on this issue by adding a +1 reaction to the original comment on this issue to add your vote to prioritization. Thanks! |
Does vector support chunking for output messages now? Or what you mean is start with the reassembling first? Thank you |
Hi @angelrib , that comment actually came from @jszwedko (#13288 (comment)) So this (#13292) is the referred to follow-up issue to track chunking support. I believe what Jesse meant is that we can probably just start with implementing chunking on the decoder side, and add the encoding side in a separate PR. |
Reviewing the code it looked like that, I just wanted to confirm it. Thank you very much! |
Chunking imho is mandatory for UDP in order to be usable, since log messages would be limited to 8192 bytes otherwise, and fail depending on content. |
Opened #20769 for addressing the decoding part. I'm currently working on it and will have it implemented soon. Just some details left |
I'm noticing that GELF does have a chunking part of its protocol too, for multi-part messages when using UDP:
I think we can split this off into a follow up issue though and just start with basic decoding support of incoming messages.
Originally posted by @jszwedko in #13288 (comment)
The text was updated successfully, but these errors were encountered: