Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default window icon #29

Open
vczh opened this issue Jan 14, 2023 · 2 comments
Open

default window icon #29

vczh opened this issue Jan 14, 2023 · 2 comments

Comments

@vczh
Copy link
Member

vczh commented Jan 14, 2023

Feel free to close it if it has been implemented.

User should be offered a way to provide the executable icon. When there is no icon assigning to GacWindow, the executable icon (if exists) will take place and display on the UI.

In Windows, user do this by compiling the application with a resource.rc, executable icon is the first icon in the list. In INativeWindow::GetIcon, if no icon is assigned, the executable icon is returned. GacUI will handle the rest to display the icon.

@roodkcab
Copy link
Member

together should be offered a way to set application id, since gtk app main loop start before GuiMain function, some application may require unique identity based on that id.

@vczh
Copy link
Member Author

vczh commented Jan 17, 2023

GuiWindow will display the default icon from INativeWindow when GuiWindow::GetIcon returns nullptr. So if all INativeWindow instances have the same default icon, they will be displayed.

In Windows, if INativeWindow::SetIcon(nullptr) is called, GetIcon returns the default icon instead of nullptr.

I believe this is some how platform depended. It is fine if gGac offers an API or a mechanism that works for gGac.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants