Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved test coverage #942

Merged
merged 6 commits into from
May 5, 2021
Merged

Improved test coverage #942

merged 6 commits into from
May 5, 2021

Conversation

radekmie
Copy link
Contributor

@radekmie radekmie commented Apr 30, 2021

This PR targets to improve our test coverage. Hopefully, we'll reach 100% once again! To do so, I:

  • Added /* istanbul ignore next */ to our btoa and global polyfills.
  • Configured tsconfig.json for target: 'ESNext' due to Errorneous coverage skipped report  istanbuljs/nyc#727.
  • Added and/or updated unit tests.
    • This actually highlighted a slight regression with handling label={null}. Nice!
  • Removed unnecessary optional chaining.

@radekmie radekmie added the Type: Feature New features and feature requests label Apr 30, 2021
@radekmie radekmie added this to the v3.4 milestone Apr 30, 2021
@radekmie radekmie requested review from Monteth and wadamek65 April 30, 2021 12:41
@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #942 (5e5a4a6) into master (7f1fddb) will increase coverage by 1.33%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #942      +/-   ##
==========================================
+ Coverage   97.48%   98.82%   +1.33%     
==========================================
  Files         202      202              
  Lines        3941     3153     -788     
  Branches      810      798      -12     
==========================================
- Hits         3842     3116     -726     
+ Misses         11        1      -10     
+ Partials       88       36      -52     
Impacted Files Coverage Δ
packages/uniforms-bootstrap3/src/DateField.tsx 100.00% <ø> (+3.70%) ⬆️
packages/uniforms-bootstrap3/src/NestField.tsx 100.00% <ø> (+5.00%) ⬆️
packages/uniforms-bootstrap4/src/DateField.tsx 100.00% <ø> (+3.57%) ⬆️
packages/uniforms-bootstrap4/src/NestField.tsx 100.00% <ø> (+5.26%) ⬆️
packages/uniforms-bootstrap5/src/DateField.tsx 100.00% <ø> (+3.57%) ⬆️
packages/uniforms-bootstrap5/src/NestField.tsx 100.00% <ø> (+5.26%) ⬆️
packages/uniforms-material/src/DateField.tsx 100.00% <ø> (+3.22%) ⬆️
packages/uniforms-material/src/NestField.tsx 100.00% <ø> (+17.64%) ⬆️
packages/uniforms-semantic/src/DateField.tsx 100.00% <ø> (+2.56%) ⬆️
packages/uniforms-semantic/src/NestField.tsx 100.00% <ø> (+4.54%) ⬆️
... and 147 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f1fddb...5e5a4a6. Read the comment docs.

@radekmie radekmie merged commit adfebba into master May 5, 2021
@radekmie radekmie deleted the improved-test-coverage branch May 5, 2021 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New features and feature requests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants