Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check read() for consistency #125

Open
martin-schlipf opened this issue Jan 16, 2024 · 2 comments
Open

Check read() for consistency #125

martin-schlipf opened this issue Jan 16, 2024 · 2 comments
Labels
Milestone

Comments

@martin-schlipf
Copy link
Collaborator

Revisit the read functionality of the various Refinery classes and make sure they behave in a consistent manner. Make a decision when elements are included as None and when they are skipped. A general idea could be that data that is added via a selection input is added whereas if it depends on the VASP setup it is set to None.

@martin-schlipf martin-schlipf added this to the Release 1.0 milestone Jan 16, 2024
@sudarshanv01
Copy link
Collaborator

Somewhat related, and writing here to make sure it is documented so I can take a look later: there is an issue with if not self._raw_data.cell.scale.is_none(): line in sturcture.py again. The issue is still the is_none() not applying to a numpy array where VaspData is expected.

Copy link

We consider issues as stale if there has been no activity in them for 10 months.

@github-actions github-actions bot added the stale label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants