Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for introduction via CoRE Link Format #29

Merged
merged 5 commits into from
Oct 25, 2022

Conversation

JKRhb
Copy link
Contributor

@JKRhb JKRhb commented Oct 21, 2022

Hi everyone!

This PR adds support for the CoRE Link Format introduction method (see https://w3c.github.io/wot-discovery/#introduction-core-rd-sec), exposing the /.well-known/wot resource as a single link under /.well-known/core (see RFC 6690).

I integrated the route into the WellKnownController controller and generalized the documentation a bit, covering both /.well-known/wot and /.well-known/core. Let me know if there is anything that should be changed :)

(Using this introduction method for HTTP does not make as much sense as it does for CoAP, since HTTP does not support multicast. However, it is a feature currently at risk in the Discovery specification, therefore I thought it would be nice if there was one (additional) implementation 🙂)

(Partially?) resolves #20.

@JKRhb JKRhb marked this pull request as ready for review October 21, 2022 15:55
Copy link
Contributor

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you really much!!! Ready to go 👍

@relu91 relu91 merged commit 6e63c28 into vaimee:main Oct 25, 2022
@relu91 relu91 mentioned this pull request Oct 25, 2022
2 tasks
@JKRhb JKRhb deleted the well-known-core branch October 26, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Core introduction method
3 participants