From 234a994b9ecbadb30c38394e89c8206d99333b03 Mon Sep 17 00:00:00 2001 From: vade Date: Fri, 27 Jan 2017 13:46:20 -0500 Subject: [PATCH] Update build.gn for Chromium framework (I think!?) so we can find Syphon.framework for linking. We still need to properly copy the bundle resources (Syphon.framework) and correctly run install_name_tool but we are doing that manually with the loader flags as : Mayalls-Object:~ vade$ install_name_tool -change Frameworks/Syphon.framework/Versions/A/Syphon @loader_path/Frameworks/Syphon.framework/Versions/A/Syphon /Users/vade/Documents/Chromium/chromium/src/out/Default/Chromium.app/Contents/Versions/58.0.2994.0/Chromium\ Framework.framework/Chromium\ Framework Assuming the Frameworks/Syphon.framework is next to the Chromium Framework binary. --- chrome/BUILD.gn | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn index 0ecc9f76b5157c..3261f759cee07e 100644 --- a/chrome/BUILD.gn +++ b/chrome/BUILD.gn @@ -465,8 +465,11 @@ if (is_win) { group("chrome") { deps = [ ":chrome_app", +# "//third_party/decklink", +# "//third_party/Syphon" ] + data_deps = [ ":chrome_app", ] @@ -481,8 +484,11 @@ if (is_win) { ":chrome_dump_syms", ] } + + } + if (enable_xpc_notifications) { bundle_data("chrome_framework_services") { sources = [ @@ -702,6 +708,8 @@ if (is_win) { ldflags = [] + ldflags += ["-F"+"../../third_party/Syphon/mac/"] + if (is_component_build) { ldflags += [ # The helper is in Chromium.app/Contents/Versions/X/Chromium Helper.app/Conents/MacOS/ @@ -1065,6 +1073,8 @@ if (is_win) { "-Wl,-order_file," + rebase_path("app/framework.order", root_build_dir), ] + ldflags += ["-F"+"../../third_party/Syphon/mac/"] + if (is_component_build) { ldflags += [ "-rpath",