Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flag to maintain tmp directory #248

Open
mbussolotto opened this issue Apr 17, 2024 · 1 comment
Open

add flag to maintain tmp directory #248

mbussolotto opened this issue Apr 17, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mbussolotto
Copy link
Member

lots of code uses:

 tmpDir, err := os.MkdirTemp("", "MYDIR-*")

to create a tmp directory where save files, used by further steps. The tmp directories are deleted using:

defer os.RemoveAll(tmpDir)

making impossible to debug it. We should add a flag to disable the defer command

@mbussolotto mbussolotto added the enhancement New feature or request label Apr 17, 2024
@cbosdo
Copy link
Contributor

cbosdo commented May 2, 2024

We could add a --keepTemp flag and hide it? The issue is that this should be used in 21 places and only 4 of them have access to global flags ATM.

@cbosdo cbosdo added the good first issue Good for newcomers label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants