Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel requests in the web socket connector #547

Open
domoritz opened this issue Oct 3, 2024 · 1 comment
Open

Parallel requests in the web socket connector #547

domoritz opened this issue Oct 3, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@domoritz
Copy link
Member

domoritz commented Oct 3, 2024

The web socket connector serializes queries as it only allows a single query at a time. We should update the connector (and the servers) to allow parallel queries. This will require sending multiple messages for arrow responses as we cannot mix JSON (for the metadata with as what query the result is for) and binary (for the arrow data).

@domoritz domoritz added enhancement New feature or request good first issue Good for newcomers labels Oct 3, 2024
@jheer
Copy link
Member

jheer commented Oct 3, 2024

As an alternative to sending multiple messages, we might use a simple custom binary format. For example: an int32 query id followed by the arrow bytes (or JSON string payload). Or variations with additional fields, such as including the query execution time (as measured in the DB), as information that might inform future cache eviction policies.

Note that I'm not endorsing this, just noting the possibility :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants