Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring ExtLibraries structure #611

Closed
sksat opened this issue Feb 14, 2024 · 0 comments · Fixed by #668
Closed

Refactoring ExtLibraries structure #611

sksat opened this issue Feb 14, 2024 · 0 comments · Fixed by #668
Assignees
Labels
major update incompatible API changes tools

Comments

@sksat
Copy link
Collaborator

sksat commented Feb 14, 2024

Details

Currently, ExtLibraries is very diffitcult to setup, understand, and maintain.

  • Directory naming conventions are out of sync with normal S2E directories
  • Duplicate responsibilities with src/library/external
  • Hard-to-manage external libraries with CMake
  • Downloading files from the Internet with CMake
  • Downloading data files (these are NOT library) from the Internet (with CMake)
    • Both build-system & runtime should be know ExtLibraries path
  • Out-of-repository install destination (../ExtLibraries)

Closing conditions

After renaming ExtLibraries or reorganizing its structure

Supplementary information

Provide any supplementary information.

@sksat sksat added the tools label Feb 14, 2024
@sksat sksat self-assigned this Feb 14, 2024
@sksat sksat added the major update incompatible API changes label Feb 15, 2024
@200km 200km added this to the Major Update v8.0.0 milestone Feb 16, 2024
@200km 200km linked a pull request Aug 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major update incompatible API changes tools
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants