Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need more information about unknown bindings #44

Open
jurgenvinju opened this issue Dec 23, 2022 · 1 comment
Open

need more information about unknown bindings #44

jurgenvinju opened this issue Dec 23, 2022 · 1 comment

Comments

@jurgenvinju
Copy link
Member

if (binding == null) {
			return makeBinding("UNKNOWN1", null, null);
}

This is from BindingsResolver but we need to know what AST node this is about to be able to debug it, or the source location of the AST node we are processing at the moment.

@jurgenvinju
Copy link
Member Author

Examples we ran into during parsing of subversion:

typedef svn_boolean_t (*filter_func_t)(const char *key);
here, *key is recognized as UNKNOWN1
static svn_error_t *filter_dir_changed(const struct svn_diff_tree_processor_t *processor, ...)
here, const struct svn_diff_tree_processor_t *processor is unknown
SVN_ERR(svn_io_remove_dir2(wc_path, TRUE, NULL, NULL, pool));
for this example, NULL is unknown

Especially when resolving the entire project it is very hard to debug these issues. If we add more diagnostics first, maybe solving each issue will be easier, but also the user of clair will be better informed and can make workarounds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant