Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow write/read/use of source mappings to/from needs.json #1156

Open
PhilipPartsch opened this issue Mar 26, 2024 · 2 comments
Open

Allow write/read/use of source mappings to/from needs.json #1156

PhilipPartsch opened this issue Mar 26, 2024 · 2 comments

Comments

@PhilipPartsch
Copy link
Contributor

Currently the lineno is been excluded from the needs.json generation. This is bad, as following tools cannot fetch the location of the needs.
So we want to add them to the needs.json export.

@chrisjsewell
Copy link
Member

Thanks @PhilipPartsch, firstly I would suggest changing the title to something like "Allow write/read/use of source mappings to/from needs.json", as I imagine lineno will probably not be useful on its own?

Secondly, I would suggest this should be under a configuration flag, since this is possibly not the general use case for external needs, and also it is maybe somewhat in opposition to #1082 (where we are trying to reduce the size of needs.json)

@PhilipPartsch PhilipPartsch changed the title lineno should be part of the needs.json Allow write/read/use of source mappings to/from needs.json Mar 26, 2024
@PhilipPartsch
Copy link
Contributor Author

I would made lineno and content_offset mandatory, as we need these information for a correct warning / error generation if content of needs are creating an issue by rendering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants