Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce versions (Semantically) in the ext helper scripts #145

Open
renatomefi opened this issue Dec 18, 2019 · 2 comments
Open

Enforce versions (Semantically) in the ext helper scripts #145

renatomefi opened this issue Dec 18, 2019 · 2 comments
Labels
Feature New feature or request

Comments

@renatomefi
Copy link
Contributor

The problem:

For instance in the example below:

We see that we aren't locking the version pecl is installing, this can lead to bugs and major versions being upgraded without the user's consent.

A proposed solution would be:

The script should take an argument (.i.e.: $1 or ENV variable) which specifies the version to be installed.

A bonus is to be able to specify the version semantically, we have to check weather pecl supports it.

@renatomefi renatomefi added the Feature New feature or request label Dec 18, 2019
@carusogabriel
Copy link
Contributor

@renatomefi Is this considered a BC? As by your proposal, we'd need to provide a rdkafka version?

@renatomefi
Copy link
Contributor Author

Good point, we could start with a flexible version and later see how to break the compatibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants