Remove wrapping request args in reactive to fix memory leak #3612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 16915b1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoviDeCroock
approved these changes
Jun 18, 2024
Merged
|
this is completely breaks reactivity support for variables, like |
|
@yurks mate chill... first and foremosta tone like that when not adding tests/... is really not appreciated I'll go through the types/... in depth tonight and get to know Vue to get everything fixed hollistically |
|
(how you can identify the tone by text question? PR was approved and immediately released) that's not about types but about reactivity. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This eliminates the memory leak since reactive always assigned new
watchEffectsto the static request object.Resolves: #3507 (comment)
Memory leak appeared in this PR #1151
Set of changes
argsinreactiveinuseQuery.tsanduseSubscription.tsThis change is not breaking, since we still do
unrefas before #1151 PR.