You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As a matter of fact, the code you pointed to in recovery.go is functionally wrong. The only way it could be done is if it were buffering a temporary http.ResponseWriter, and only flushing it when the handler returned. The current code will fail at line 161 as WriteHeader() will ignore the status if data was already written (that's how HTTP works) and the stack data will just be appended to whatever was already streamed to the user. That's bad.
The text was updated successfully, but these errors were encountered:
There is a comment here regarding https://github.com/urfave/negroni/blob/master/recovery.go#L160:
maruel/panicparse#81 (comment)
The text was updated successfully, but these errors were encountered: