Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PrintStack to false as default #214

Open
bragagia opened this issue Jan 15, 2018 · 2 comments
Open

PrintStack to false as default #214

bragagia opened this issue Jan 15, 2018 · 2 comments
Labels
future

Comments

@bragagia
Copy link

PrintStack should be set to false as default in negroni.Recovery.
It should be set willingly to true only in a protected development environment but never in production.
@jszwedko
Copy link
Contributor

jszwedko commented Jan 21, 2018 •
edited
Loading

Hi @baijum,

While I agree with you that false makes a more sensible default for this, unfortunately this default has existed since the Recovery middleware was introduced in 6939988 so hesitate to break compatibility and change it.

If there is ever a v2 of negroni, this should definitely be updated. I'll mark this as future for now.

Thanks!

@AleF83 AleF83 mentioned this issue May 15, 2018
Merged
@erikacarvalho
Copy link

hey @Streppel check this out 🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
future
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jszwedko @bragagia @erikacarvalho