Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose shell completions scripts in by default in the completion command #1904

Open
3 tasks done
bartekpacia opened this issue May 2, 2024 · 7 comments
Open
3 tasks done
Assignees
Labels
area/v3 relates to / is being considered for v3 kind/feature describes a code enhancement / feature request

Comments

@bartekpacia
Copy link
Member

bartekpacia commented May 2, 2024

Checklist

  • Are you running the latest v3 release? The list of releases is here.
  • Did you check the manual for your release? The v3 manual is here.
  • Did you perform a search about this feature? Here's the GitHub guide about searching.

What problem does this solve?

Makes it easier for developers to add shell completion to the CLI tools they're building with urfave/cli/v3. This would make completion installation the same as the popular Cobra library, that is:

myapp completion zsh prints the completion script for zsh. The user of the CLI gets to decide what to do with it:

  • put it into completions directory: myapp completion zsh > /opt/homebrew/share/zsh/site-functions/_myapp (on macOS), or
  • source it in-place: . <(myapp completion zsh)

We already have completion scripts in this repository for all major popular shells (bash, zsh, pwsh), and furthermore, these scripts are already bundled with the module:

cli/completion.go

Lines 14 to 16 in 204d34f

var (
//go:embed autocomplete
autoCompleteFS embed.FS

Solution description

By default, each CLI app made with urfave/cli/v3 should have the completion command (hidden by default)

I don't think this could be brought into v2, because it would break if the developer already defined the completion command.

Describe alternatives you've considered

The alternative is the current situation – developers have to copy , which is unnecessary work, given that the completion files are embedded in urfave/cli anyway.

Resources used

@bartekpacia bartekpacia added status/triage maintainers still need to look into this area/v3 relates to / is being considered for v3 labels May 2, 2024
@bartekpacia bartekpacia changed the title your feature title goes here Expose shell completions scripts in by default in the completion command May 2, 2024
@bartekpacia bartekpacia added kind/feature describes a code enhancement / feature request and removed status/triage maintainers still need to look into this labels May 2, 2024
@dearchap
Copy link
Contributor

dearchap commented May 5, 2024

@bartekpacia I dont understand. The "generate-completion" is a hidden command in urfave/cli/v3. So if user invokes

myapp generate-completion zsh

It will output the zsh completion script which can be copied by user and sourced.

@bartekpacia
Copy link
Member Author

@dearchap Thank you for pointing it out – I wasn't aware of it.

It doesn't look like this feature is documented anywhere yet – but this may be actually a good thing, because v3 is at alpha, so we could:

  • rename default name to completion (to match Cobra - let users use their muscle memory)
  • make the completion script not require $PROG to be set – use CLI app name instead.
  • write docs! :D

@meatballhat
Copy link
Member

meatballhat commented May 5, 2024

@bartekpacia Thank you for bringing this up!

  • rename default name to completion (to match Cobra - let users use their muscle memory)

SGTM 👍🏼

  • make the completion script not require $PROG to be set – use CLI app name instead.

SGTM 👍🏼

  • write docs! :D

SGTM 👍🏼

WDYT about creating targeted issues for each of these?

@bartekpacia
Copy link
Member Author

@meatballhat I think all these changes should be ideally made in a single PR, to keep them atomic and easy to revert - so a single issue to track them is enough for me.

That said if you disagree I can of course create the issues.

@meatballhat
Copy link
Member

@bartekpacia Single issue also works for me 👍🏼 I didn't want to pressure you (or anyone else) to get it all done in one shot 😁

@dearchap
Copy link
Contributor

@bartekpacia do you want to take this up ?

@bartekpacia
Copy link
Member Author

bartekpacia commented Oct 26, 2024

@dearchap yes! I assigned myself:)

no promise on the timeline though I'd like to get it done in the next month or so:(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/v3 relates to / is being considered for v3 kind/feature describes a code enhancement / feature request
Projects
None yet
Development

No branches or pull requests

3 participants