Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the documentation tests so that they run against the code in the current branch #1006

Open
coilysiren opened this issue Dec 21, 2019 · 1 comment
Open

Fix the documentation tests so that they run against the code in the current branch #1006

coilysiren opened this issue Dec 21, 2019 · 1 comment
Assignees
@asahasrabuddhe
Labels
area/v2 relates to / is being considered for v2 help wanted please help if you can! kind/maintenance about releasing / CI / Github / other kind of "meta" project maintenance work status/confirmed confirmed to be valid, but work has yet to start
Milestone
Release 2.x

Comments

@coilysiren
Copy link
Member

surfaced via #997 (comment)
@coilysiren coilysiren added help wanted please help if you can! status/confirmed confirmed to be valid, but work has yet to start kind/maintenance about releasing / CI / Github / other kind of "meta" project maintenance work labels Dec 21, 2019
@coilysiren coilysiren mentioned this issue Dec 21, 2019
Merged
@coilysiren coilysiren changed the title Fix the documentation tests so that they run against the code in the current branch maint: fix the documentation tests so that they run against the code in the current branch Dec 24, 2019
@coilysiren
Copy link
Member Author

Extra reason to fix this: new version pushes and result in all of our PR builds suddenly breaking => https://github.com/urfave/cli/pull/1001/checks?check_run_id=362350191

@coilysiren coilysiren mentioned this issue Dec 24, 2019
Merged
@asahasrabuddhe asahasrabuddhe self-assigned this Jan 26, 2020
@meatballhat meatballhat changed the title maint: fix the documentation tests so that they run against the code in the current branch Fix the documentation tests so that they run against the code in the current branch Apr 21, 2022
@meatballhat meatballhat added the area/v2 relates to / is being considered for v2 label Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asahasrabuddhe asahasrabuddhe

Labels
area/v2 relates to / is being considered for v2 help wanted please help if you can! kind/maintenance about releasing / CI / Github / other kind of "meta" project maintenance work status/confirmed confirmed to be valid, but work has yet to start
Projects
None yet
Milestone
Release 2.x
Development

No branches or pull requests
3 participants
@meatballhat @coilysiren @asahasrabuddhe