Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to show channel list on a separate sidebar (like the official Discord client) #221

Closed
yusdacra opened this issue Sep 10, 2023 · 26 comments · Fixed by #242
Closed

Comments

@yusdacra
Copy link

This would be really nice (for me anyway) since I find the current UI really tiring to use with all the scrolling that I have to do if I want to find a channel.

@ouwou
Copy link
Member

ouwou commented Sep 20, 2023

this seems like a particularly desired feature so ill have a go at doing it after i finish up the member list rewrite. i personally prefer the existing channel list UI so ill make it an option to use either. id also be interested in hearing if theres anything i could do differently from discord's official UI that would make it better

@yusdacra
Copy link
Author

I'm not really sure what would be a better UI/UX unfortunately. This is unrelated to this but, being able to pin channels to somewhere always reachable (like the guild list) might also help with some issues.

@jernejs
Copy link

jernejs commented Sep 25, 2023

A killer feature for me would be being able to favorite channels from different guilds ("servers") – I'm in something like 30 guilds, and only interested in a few channels from each. In Ripcord, I had these channels pinned in Favorites.

@ouwou
Copy link
Member

ouwou commented Oct 9, 2023

would it work if you had the classic discord-style guild list with the icons on the left and the channel list that exists now on the right with the channel list only showing the selected guild? or in other words is there anything wrong with the channel list that exists now apart from the fact its not just the desired guild thats visible? (reusing the widget would make my life a lot easier)

@jernejs
Copy link

jernejs commented Oct 9, 2023

For my suggestion (favorites), the easiest would be to just add a virtual Favorites guild to the list, and let me pin channels from different guilds in there (you'd need to add the guild icon in front of the channel name though, since a ton of guilds use #general channel).
I actually prefer how Abaddon shows the guilds and channels over Discord, since it lets me quickly move between channels on different guilds (saves some mouse clicking).

@ouwou
Copy link
Member

ouwou commented Oct 25, 2023

not sure when itll be done but you can take a peek at #242 to see the progress. right now its extremely basic and kinda buggy but im working on it

@ouwou
Copy link
Member

ouwou commented Jan 9, 2024

been working on it more lately. id be open to some feedback as far as functionality but also appearance (even tho i know it still needs some tweaking). classic-channels branch, or windows download. i know we like favorites but thatll come separately after this is done

@32bitx64bit
Copy link

Can't wait for it to be available so I can compile it.

@ouwou
Copy link
Member

ouwou commented Jan 14, 2024

Can't wait for it to be available so I can compile it.

well you can try compiling it from the right branch now if you want

@32bitx64bit
Copy link

32bitx64bit commented Jan 16, 2024

Can't wait for it to be available so I can compile it.

well you can try compiling it from the right branch now if you want

Exactly how? I'm not really in the know how's of Github and how to git a branch of something.

Edit figured it out. Heres the command for anyone looking to do the same.
git clone --branch classic-channels https://github.com/uowuo/abaddon --recurse-submodules="subprojects" && cd abaddon

@32bitx64bit
Copy link

Can't wait for it to be available so I can compile it.

well you can try compiling it from the right branch now if you want

Exactly how? I'm not really in the know how's of Github and how to git a branch of something.

Edit figured it out. Heres the command for anyone looking to do the same. git clone --branch classic-channels https://github.com/uowuo/abaddon --recurse-submodules="subprojects" && cd abaddon

Progress looking solid.
Like it a lot more than the previous way. Just makes it so much more organized!
Though would be nice having the sidebar just be invisible. or super tiny.

@ouwou
Copy link
Member

ouwou commented Jan 17, 2024

Though would be nice having the sidebar just be invisible. or super tiny.

could you elaborate? not sure what u mean

@32bitx64bit
Copy link

32bitx64bit commented Jan 19, 2024

Though would be nice having the sidebar just be invisible. or super tiny.

could you elaborate? not sure what u mean
raw

The scrollbar.

This was done on KDE

@ouwou
Copy link
Member

ouwou commented Jan 20, 2024

it should be hidden unless you have your mouse in the scroll region. if you want it to never show up, i can add an option for that (and in that case, do you want the option for just the server icons, or channel list too?). and aside from visibility, its appearance is controlled by your theme

@32bitx64bit
Copy link

it should be hidden unless you have your mouse in the scroll region. if you want it to never show up, i can add an option for that (and in that case, do you want the option for just the server icons, or channel list too?). and aside from visibility, its appearance is controlled by your theme

A option would be nice to disable the scrollbar. :D

@ouwou
Copy link
Member

ouwou commented Jan 21, 2024

A option would be nice to disable the scrollbar. :D

ok done you can do

[style]
classic_guild_scroll_policy=never
classic_channel_scroll_policy=never

(or "always" or "automatic" which is default)

@32bitx64bit
Copy link

32bitx64bit commented Jan 21, 2024

Seems like when I recompile, the sidebar returns to what it used to be. Might wanna look into that.

Also seems that when you disable the scrollbar, scrolling is just disabled entirely. Just wanted the bar hidden, not scrolling. Just to clear things up. Or its a bug, idk which tbh.

@32bitx64bit
Copy link

32bitx64bit commented Jan 21, 2024

Seems like when I recompile, the sidebar returns to what it used to be. Might wanna look into that.

Also seems that when you disable the scrollbar, scrolling is just disabled entirely. Just wanted the bar hidden, not scrolling. Just to clear things up. Or its a bug, idk which tbh.

Opened a pull to fix classic channels not being default.
As atleast in my opinion, it probably should be.
#262

@ouwou
Copy link
Member

ouwou commented Jan 21, 2024

Also seems that when you disable the scrollbar, scrolling is just disabled entirely. Just wanted the bar hidden, not scrolling. Just to clear things up. Or its a bug, idk which tbh.

oh. yeah. im not smart. i forgot thats how scrolling works in gtk (not sure how i didnt catch that). time to revert it and ill think of something else

@ouwou
Copy link
Member

ouwou commented Jan 23, 2024

i think youll just have to use css to hide the scroll bars, try this (needs latest commit)

.channel-browser-pane scrollbar {
	border: none;
}

.channel-browser-pane scrollbar slider {
	border: none;
	margin: 0;
	min-width: 0;
	min-height: 0;
}

@32bitx64bit
Copy link

i think youll just have to use css to hide the scroll bars, try this (needs latest commit)

.channel-browser-pane scrollbar {
	border: none;
}

.channel-browser-pane scrollbar slider {
	border: none;
	margin: 0;
	min-width: 0;
	min-height: 0;
}

Hi, sadly my discord account is currently disabled. I'll try this asap.
But yk, discord support slow.

@32bitx64bit
Copy link

i think youll just have to use css to hide the scroll bars, try this (needs latest commit)

.channel-browser-pane scrollbar {
	border: none;
}

.channel-browser-pane scrollbar slider {
	border: none;
	margin: 0;
	min-width: 0;
	min-height: 0;
}

Hi, sadly my discord account is currently disabled. I'll try this asap. But yk, discord support slow.

This bit of code doesn't work

@32bitx64bit
Copy link

Also a little update, ordering just isn't correct. nothing is in order properly. ITs all random.

@ouwou
Copy link
Member

ouwou commented Feb 4, 2024

Also a little update, ordering just isn't correct. nothing is in order properly. ITs all random.

i think i fixed that yesterday. try on the newest commit

This bit of code doesn't work

also check if this is still a problem on the newest commit. i made it a default (but just for the server list. if it works for the server list maybe ill add it to the channel list too)

@32bitx64bit
Copy link

32bitx64bit commented Feb 4, 2024

Also a little update, ordering just isn't correct. nothing is in order properly. ITs all random.

i think i fixed that yesterday. try on the newest commit

This bit of code doesn't work

also check if this is still a problem on the newest commit. i made it a default (but just for the server list. if it works for the server list maybe ill add it to the channel list too)

I just compiled it today, the fix didn't work.
And the sidebar does hide, until you hover, which is fine. Its less annoying now from what it was.

@ouwou
Copy link
Member

ouwou commented Mar 6, 2024

i really wanna merge this already and i think its basically ready so if theres any last minute bugs or suggestions i would like to hear them
@32bitx64bit also maybe you can see if you can replicate the ordering issue. it works fine for me. only issue i have heard from someone is in the private messages section but i cant replicate that either

@ouwou ouwou closed this as completed in #242 Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@jernejs @yusdacra @ouwou @32bitx64bit and others