Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Replace dependency "fp16". It is outdated. #519

Open
2 of 3 tasks
Spixmaster opened this issue Nov 2, 2024 · 4 comments
Open
2 of 3 tasks

Feature: Replace dependency "fp16". It is outdated. #519

Spixmaster opened this issue Nov 2, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@Spixmaster
Copy link
Contributor

Describe what you are looking for

Can the dependency fp16 be replaced? It not well maintained and does not even have a tag. This makes it horrible to package. See https://aur.archlinux.org/packages/usearch.

Can you contribute to the implementation?

  • I can contribute

Is your feature request specific to a certain interface?

It applies to everything

Contact Details

No response

Is there an existing issue for this?

  • I have searched the existing issues

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Spixmaster Spixmaster added the enhancement New feature or request label Nov 2, 2024
@Spixmaster Spixmaster changed the title Feature: Replace dependency fp16. It is outdated. Feature: Replace dependency "fp16". It is outdated. Nov 2, 2024
@ashvardanian
Copy link
Contributor

It is an optional dependency, that can be disabled, but I am not sure what new functionality can be expected from an f16/f32 conversion package, @Spixmaster?

@Spixmaster
Copy link
Contributor Author

Spixmaster commented Nov 2, 2024

It may be my fault but for me it is not optional but mandatory. When trying to compile with this library included, the header for fp16 is needed.

I compiled with -D USEARCH_USE_FP16LIB=OFF. This did not work. I am wondering what that option should even do because no library (.a or .so) is built. As far as I understand, this is a header-only library.

@Spixmaster
Copy link
Contributor Author

I took a further look at the source code. The functionality is given by SimSIMD. Why even bother with FP16? The commit of FP16 that is used here as a submodule is over three years old and the maintainter of FP16 does not merge pull requests and does not even tag a version.

I want to properly package this library for Arch Linux and FP16 is a pain to work with and not even needed.

@Spixmaster
Copy link
Contributor Author

See #526.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants