Skip to content
This repository has been archived by the owner on Jun 2, 2023. It is now read-only.

Is there an option to disable Pwn'd password check #595

Open
thedragonkeeper opened this issue Sep 4, 2020 · 22 comments
Open

Is there an option to disable Pwn'd password check #595

thedragonkeeper opened this issue Sep 4, 2020 · 22 comments
Assignees
Labels
bug Something doesn't work!

Comments

@thedragonkeeper
Copy link

I want to disable the check of is password is pwn'd but i cant find an option for it

Is this available somewhere or can it be added ?

@geoperez
Copy link
Member

geoperez commented Sep 4, 2020

No, there is not an option. Let me add it.

Good catch!

@geoperez geoperez self-assigned this Sep 4, 2020
@geoperez geoperez added the bug Something doesn't work! label Sep 4, 2020
@gpet-stack
Copy link

Any update ?

@ag0r4n
Copy link

ag0r4n commented Sep 11, 2020

Same problem here, passcore doesn' work behind a firewall not allowing internet access

@gpet-stack
Copy link

Passcore does not respect the proxy settings.

@ag0r4n
Copy link

ag0r4n commented Sep 11, 2020

Indeed, but at least it should work with no internet access ?

@gpet-stack
Copy link

I think that the Pwned Passwords API is always called.

@thedragonkeeper
Copy link
Author

I believe it is always called , hence the issue posted, it will also sometimes lock up while trying to make the request. This makes passcore bad method for self service if you are behind a firewall/webfilter/proxy.

@stale
Copy link

stale bot commented Nov 14, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Problem, or not; this won't be fixed here at least. label Nov 14, 2020
@insignia96
Copy link

Just wondering if we could get an update on this issue. I am also running it on a server without Internet access and have patched this issue myself by rebuilding the software from the source with this check bypassed.

@stale stale bot removed the wontfix Problem, or not; this won't be fixed here at least. label Nov 18, 2020
@tablaty
Copy link

tablaty commented Dec 2, 2020

I also would like to know if this is being looked at. I updated to this latest version, but I had to revert back because of this feature. I made the process too long, it makes the service useless in my environment.
thanks

@geoperez geoperez assigned antonioi88 and unassigned geoperez Dec 10, 2020
@geoperez
Copy link
Member

@antonioi88 can you help us with this?

@x0341
Copy link

x0341 commented Dec 28, 2020

any updates ? the same issue even if the password and policy is good have always the same problem as this ticket.

@IamPhilG
Copy link

IamPhilG commented Dec 30, 2020

I do have the same issue.

I have checked against the API itself the password and in the end it is a safe password.
Due to my infrastructure, here, I am not able to allow calls to this API from the Backend. Is this guess about “the call to the api from the backend” true ?
Then with this implementation and without an option to not use the API check this version will not be for me.

A bit of guidance to the files to modify in the source code and I’ll do it myself.

Any update would be really appreciated.

@cservs
Copy link

cservs commented Apr 7, 2021

Any updates ? Yes, i need full offline mode, without allowing internet access!

@stale
Copy link

stale bot commented Jun 9, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Problem, or not; this won't be fixed here at least. label Jun 9, 2021
@DartZEK
Copy link

DartZEK commented Jun 16, 2021

Any updates? I'd prefer full offline mode too

@stale stale bot removed the wontfix Problem, or not; this won't be fixed here at least. label Jun 16, 2021
@simonai1254
Copy link

I am running passcore in a closed environment too and would be happy to disable the checks (even though it's a great feature to have them). I had to downgrade to 4.2.3 to get it working without stumbling accross issue #605

@JoopIdema
Copy link

Just use version 3.61. Problem solved.

@simonai1254
Copy link

@JoopIdema IMHO old versions should not be the solution for a problem like this, this should be also pretty easy to fix...

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Problem, or not; this won't be fixed here at least. label Apr 16, 2022
@simonai1254
Copy link

Keepalive

@stale stale bot removed the wontfix Problem, or not; this won't be fixed here at least. label Apr 19, 2022
@dc540
Copy link

dc540 commented Apr 19, 2023

Is recompiling/manual patching or downgrading really the only way to fix this or work around it? Feels like much of the use-case for this application is closed-network usage.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something doesn't work!
Projects
None yet
Development

No branches or pull requests