Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(winterjs): rework and enable tests #138

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(winterjs): rework and enable tests #138

wants to merge 3 commits into from

Conversation

Arshia001
Copy link

🔗 Linked issue

#85

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR introduces several improvements to the WinterJS tests:

  • Rework WinterJS test code to use exec command
  • Use recently implemented process.version support in WinterJS to report the version number
  • Rename 'wasmer' to 'winterjs' across the codebase, which is the correct name for the JS runtime
  • Add zero-argument constructor error messages from WinterJS to fix a few false negatives

Also appears to indirectly resolve #85, as more recent versions of WinterJS use an improved event loop that should resolve the hanging issue.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly. - There's nothing to update I believe.

Note: WinterJS 1.2.0 is needed to support the changes in this PR; specifically, the process.version property is missing in version 1.1.0. As such, the PR shall remain a draft until that version is published.

@Arshia001
* Rework WinterJS test code to use exec command
ccf462d 
* Use recently implemented process.version support in WinterJS to report the version number
* Rename 'wasmer' to 'winterjs' across the codebase, which is the correct name for the JS runtime
* Add zero-argument constructor error messages from WinterJS to fix a few false negatives
@Arshia001 Arshia001 mentioned this pull request Jun 7, 2024
Open
@pi0 pi0 changed the title fix: Rework and enable WinterJS tests fix(winterjs): rework and enable tests Jun 7, 2024
@Arshia001 Arshia001 marked this pull request as ready for review June 19, 2024 07:12
@Arshia001
Copy link
Author

@pi0 @ascorbic fyi, this PR is now ready for review.

@Arshia001
Copy link
Author

Interesting, it seems there's still a timeout... I'll investigate this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wasmer tests hanging in CI
1 participant
@Arshia001