docs/contributing: Document Co-authored-by usage #242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanJum
added
documentation
mariasfiraiala
approved these changes
May 8, 2023
There was a problem hiding this comment.
Nice. Thanks a lot for this @StefanJum!
Reviewed-by: Maria Sfiraiala [email protected]
|
Sorry for bumping in, just wanted to say that there is a typo in the commit message and the title of the PR. It should be |
4 tasks
Since we started using `Co-authored-by:` tags in commit messages, this should be documented on the `contributing/` page. Signed-off-by: Stefan Jumarea <[email protected]>
StefanJum
force-pushed
the
StefanJum/add-coauthored-by-info
branch
from
13d971a to
8268f04
Compare
StefanJum
changed the title
|
Fixed @RaduNichita, thanks 💯 |
|
@StefanJum , could you please rebase the PR? |
|
Outdated, will be addressed in a new pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we started using
Co-authored-by:tags in commit messages, this should be documented on thecontributing/page.